Problem/Motivation

The module styling uses CSS variables for styling which are usually provided by gin

Steps to reproduce

Choose a theme without styling for dialog boxes
The dialog box will be unstyled

Proposed resolution

- provide fall-backs to gin variables used

/* Borrowed from CyborgTranslate's css/disclaimer.css which had to deal with the same problem of the core modal using gin/admin stylings but gin not being available to visitors. */
.dismissableblocks-disclaimer-modal.ui-widget.ui-front {
  z-index: 1000;
  border: solid black 3px !important;
  background: white;
  --ct-gin-border-color-layer: var(--gin-border-color-layer, rgba(0, 0, 0, 0.08));
  --ct-gin-border-m: var(--gin-border-m, .5rem);
  --ct-gin-bg-app: var(--gin-bg-app, rgb(249, 251, 248)); }
  .dismissableblocks-disclaimer-modal.ui-widget.ui-front .ui-dialog .ui-dialog-titlebar {
    line-height: 1.2;
    padding: 1rem 1.5rem;
    background: #1b1b1d;
    border: 0 none;
    border-radius: 0;
    position: relative; }
  .dismissableblocks-disclaimer-modal.ui-widget.ui-front .ui-dialog .ui-widget-content.ui-dialog-content {
    padding-left: 1.5rem;
    padding-right: 1.5rem;
    padding-top: .5rem;
    padding-bottom: .25rem; }
  .dismissableblocks-disclaimer-modal.ui-widget.ui-front .ui-dialog .ui-widget-content.ui-dialog-buttonpane {
    padding: .75rem 1.5rem;
    border-top: 1px solid var(--ct-gin-border-color-layer);
    border-bottom-left-radius: var(--ct-gin-border-m);
    border-bottom-right-radius: var(--ct-gin-border-m);

Remaining tasks

- css has already been added
- review

User interface changes

- prettier

API changes

- changes to dismiss_and_remember.css

Data model changes

N/A

Comments

wolcen created an issue. See original summary.

  • mlncn committed 72c77b3d on 1.0.x
    Issue #3431462 by mlncn: Disclaimer lacks background and other basic...
mlncn’s picture

Issue summary: View changes
Status: Active » Needs review
jacobupal’s picture

[commented instead of edited: oops]

jacobupal’s picture

Issue summary: View changes

  • jacobupal committed d8171f40 on 1.0.x
    Issue #3431462: Cleaned up use of gin variable fallbacks in...
jacobupal’s picture

Status: Needs review » Fixed

Marking as fixed, and crediting myself, wolcen and mlncn

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.