Problem/Motivation

Adjust FormBuilder code to the changes in typehinting.

Proposed resolution

Add the variable-length argument to getForm and submitForm methods.

Issue fork drupal-3431285

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Committers can you please move credit from #3236391: (outdated) Replace func_get_args with variable-length argument in FormBuilder.

mondrake opened merge request !7075

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Refactoring seems fine.

Question was there a change record for when it was first added? Don't know if the CR should be updated to include this ticket? Not sure policy on that

mondrake’s picture

mondrake
Location 🇮🇹
commented
Related issues: +#3236391: (outdated) Replace func_get_args with variable-length argument in FormBuilder, +#3355839: Prepare FormBuilder for variadic functions

Adding related issues. The change was prepared in #3355839: Prepare FormBuilder for variadic functions, the CR there is generic though. Do we need a separate CR?

smustgrave’s picture

smustgrave commented

I would say probably not. Not sure if this issue should be added to the published CR. Will lean on a committer for that one.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Yes we should have a dedicated change record for this one given it's an interface change and because the previous CR was for how to deprecate, not the deprecation itself, we can't add it onto that one.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs work » Reviewed & tested by the community

Added CR

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: -Needs change record

catch credited alexpott.

catch credited jidrone.

catch credited longwave.

catch credited xjm.

catch’s picture

catch
he/him
Primary language English
commented

  • catch committed c1444692 on 11.x 
    Issue #3431285 by mondrake, alexpott, jidrone, xjm, longwave: Replace...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

@mondrake fwiw it should have been possible to open a new branch with a new MR for #3236391: (outdated) Replace func_get_args with variable-length argument in FormBuilder but since this is now a follow-up for another issue I think it's OK to continue here anyway.

Thanks for the CR. Committed/pushed to 11.x, thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented

#17 @catch I tried that - but the original fork was so old it did not have the 11.x branch reference, so I could not create a new branch against that. What would be the process in that case, is that documented anywhere? Thx

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@mondrake assuming origin is the core repo you can do

$ git fetch origin 11.x
$ git push drupal-1234567 11.x

to mirror 11.x from core into the fork, and then raise MRs against it

mondrake’s picture

mondrake
Location 🇮🇹
commented

#19 great thanks

mondrake closed merge request !7075

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.