Problem/Motivation

Apply necessary styles and CSS structure for the Drawer to function across all viewports.

Proposed resolution

Apply the new designs to the drawer:

Please use the Figma link to get the specs about spacing, font styles and colors.

Remaining tasks

Implement the styles.

User interface changes

The new drawer will have the new design system styles applied.

CommentFileSizeAuthor
#5 drawer.png266.16 KBckrina

Issue fork navigation-3427657

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

KeyboardCowboy created an issue. See original summary.

ravi kant’s picture

ravi kant commented
Status: Active » Closed (duplicate)

This is duplicate of https://www.drupal.org/project/navigation/issues/3427654

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Title: Implement Styles and Structure » Implement the new designs to the drawer
Status: Closed (duplicate) » Postponed
Issue tags: +Needs design
Related issues: +#3426606: [META] Implement the final design system

This is not a duplicate, it just needs more info. We're still working on defining: when we finish the designs (which are being worked in #3426606: [META] Implement the final design system ) we'll add more details here. Postponing this until then so this doesn't confuse contributors looking for work.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Title: Implement the new designs to the drawer » [PP-1] Implement the new designs to the drawer
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes
StatusFileSize
new drawer.png266.16 KB
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Title: [PP-1] Implement the new designs to the drawer » Implement the new designs to the drawer
Status: Postponed » Active
Issue tags: -Needs design

This is ready to go!

bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented
Assigned: Unassigned » bronzehedwick
bronzehedwick’s picture

bronzehedwick
he/him
Location New York
commented

bronzehedwick opened merge request !210

finnsky’s picture

finnsky commented
Assigned: bronzehedwick » Unassigned
Status: Active » Needs review

Hello all!
It was not really clean in ticket description that this ticket about new styles of submenus. So I worked from scratch here.

I've added mostly everything. Please review.

Storybook for example.

https://sparkling-gaufre-c402f2.netlify.app/iframe.html?args=&id=page--b...

finnsky opened merge request !212

finnsky’s picture

finnsky commented

I can merge @bronzehedwick 's changes to my MR tonight.

ckrina changed the visibility of the branch 3427657-submenus to hidden.

ckrina changed the visibility of the branch 3427657-submenus to active.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Fixed

I’ve added the changes Chris had done and the missing shadows and merged it. W can get into details in follow-ups so this big chunk of works doesn’t block anything. Thanks both for the work here!

  • ckrina committed 98df61bc on 1.x authored by finnsky 
    Added 3rd level. Existing styles rework - #3427657

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bronzehedwick closed merge request !210