Problem/Motivation

When you open a field modal (e.g. for 'Edit field Rendered HTML output'), the Save button is in the modal's black bar at the bottom, but the cancel link isn't.

MR coming!

Steps to reproduce

Proposed resolution

Remaining tasks

CommentFileSizeAuthor
#4 search_api-issue-3427391-after.png85.44 KBmatias
#4 search_api-issue-3427391-before.png89.45 KBmatias

Issue fork search_api-3427391

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review

joachim opened merge request !115

matias’s picture

matias commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new search_api-issue-3427391-before.png89.45 KB
new search_api-issue-3427391-after.png85.44 KB

It looks good to me. Now the Cancel link shows in the correct place, and the solution is consistent with how other dialogs in Drupal core do it.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Makes sense, thanks!
Merged.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.