Problem/Motivation

I am getting the following unused services into the /src/EventSubscriber/RedirectSubscriber.php file

  1. $this->currentPathStack = $currentPathStack;
  2. $this->stringTranslation = $stringTranslation;

Steps to reproduce

Install the 8.x-3.0 version module

Proposed resolution

I have created a patch to fix the unused services.

Remaining tasks

Review the patch and add it to the next release.

CommentFileSizeAuthor
#2 unused_services-3427268-2.patch3.11 KBrakesh.drupal

Issue fork url_redirect-3427268

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rakesh.drupal created an issue. See original summary.

rakesh.drupal’s picture

rakesh.drupal commented
StatusFileSize
new unused_services-3427268-2.patch3.11 KB

Removed the unused services from the services.yml and RedirectSubscriber.php files.

rakesh.drupal’s picture

rakesh.drupal commented
Assigned: rakesh.drupal » Unassigned
Status: Active » Needs review
grask0’s picture

grask0 commented
Status: Needs review » Reviewed & tested by the community

Hello @rakesh.drupal

Thanks for the patch!
I’ve reviewed the changes and thoroughly tested everything, and it all works fine on my end.
Let me know if there’s anything else you’d like me to verify.

grask0’s picture

grask0 commented
Version: 8.x-3.0 » 8.x-3.x-dev

grask0 opened merge request !6

  • grask0 committed cdd49a39 on 8.x-3.x 
    fix by rakesh.drupal: #3427268 Unused services from services.yml.
grask0’s picture

grask0 commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.