Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsAreaplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3426959

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

sorlov made their first commit to this issue’s fork.

sorlov opened merge request !7047

sorlov’s picture

sorlov commented
Status: Active » Needs work
sorlov’s picture

sorlov commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Appears to have test failure and MR is in draft.

sorlov’s picture

sorlov commented
Status: Needs work » Needs review
mstrelan’s picture

mstrelan commented
Status: Needs review » Needs work

Same suggestions as #3426961-10: Convert ViewsSort plugin discovery to attributes

sorlov’s picture

sorlov commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

In core.api.php there's an example using @ViewsArea. Think it would be good idea to update the example if using attributes now vs annotations.

Ruturaj Chaubey made their first commit to this issue’s fork.

sorlov’s picture

sorlov commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Appears all instances have been replaced.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Re #10 I'm going to revert that from the MR. We can't change that yet and ViewsArea annotation still exists so the docs are not wrong. Can we get a follow-up to focus on those docs only? I think we can only change them once ContentEntityType has been made an attribute.

Committed and pushed 5aaf92bb93 to 11.x and 79460f42a3 to 10.3.x. Thanks!

  • alexpott committed 79460f42 on 10.3.x 
    Issue #3426959: Convert ViewsArea plugin discovery to attributes

(...

  • alexpott committed 5aaf92bb on 11.x 
    Issue #3426959: Convert ViewsArea plugin discovery to attributes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.