Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\views\Annotation\ViewsFilterplugins to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attribute - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3426957

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !7036

mstrelan’s picture

mstrelan commented
Status: Active » Postponed

Postponed on #3426955: Convert ViewsField plugin discovery to attributes which has the required changes to ViewsHandlerManager.

sorlov made their first commit to this issue’s fork.

sorlov’s picture

sorlov commented
Status: Postponed » Needs review

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed

#3426955: Convert ViewsField plugin discovery to attributes isn't in yet.

Just landed but this issue probably should have remained postponed to avoid the confusion.

smustgrave’s picture

smustgrave commented
Status: Postponed » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Had some bandwidth and rebased which resolved the test failure and MR wasn't
in draft so went ahead and reviewed.

Searching core all 41 instances of @ViewsFilter have been replaced

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8aa3632c61 to 11.x and 2ed3680d12 to 10.3.x. Thanks!

  • alexpott committed 2ed3680d on 10.3.x 
    Issue #3426957 by sorlov, smustgrave, mstrelan: Convert ViewsFilter...

  • alexpott committed 8aa3632c on 11.x 
    Issue #3426957 by sorlov, smustgrave, mstrelan: Convert ViewsFilter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mstrelan closed merge request !7036