Closed (fixed)
Project:
Feeds
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Mar 2024 at 11:20 UTC
Updated:
25 Mar 2024 at 11:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Dmitrii_Zadorozhnyi commentedComment #3
megachrizThanks for the patch, but I think there's a small error in it:
I think that the parameters 'ISO-8859-1' and 'UTF-8' need to be swapped:
$string,$to_encoding,$from_encoding. So the desired encoding of the result, in this case 'UTF-8' is the second parameter. The third parameter is the current encoding used to interpret string, in this case ' ISO-8859-1'.By the way: I see that the tests report much more PHP 8.2 deprecations, but these could be handled in an other issue.
Comment #4
Dmitrii_Zadorozhnyi commentedFixed
Comment #6
megachrizThanks! Committed #4.
Comment #7
Dmitrii_Zadorozhnyi commented