Problem/Motivation

You're required to modify the package name as you've specified 'Package: Custom'. If this module doesn't fall into any specific category, you can designate it as 'Package: Other'

CommentFileSizeAuthor
#5 Screenshot 2024-03-07 at 3.33.13 PM.png103.49 KByashingole
#5 Screenshot 2024-03-07 at 3.33.05 PM.png204.03 KByashingole
#2 hybridlogin.patch373 bytesdiksha@lnwebworks
hybridlogin.patch373 bytesdiksha@lnwebworks

Issue fork hybrid_login-3426273

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Diksha@lnwebworks created an issue. See original summary.

diksha@lnwebworks’s picture

diksha@lnwebworks commented
StatusFileSize
new hybridlogin.patch373 bytes
diksha@lnwebworks’s picture

diksha@lnwebworks commented

Hi @Josh Minarick , @majorrobot

I have created a patch for the above issue
Please review it once

Thank you

diksha@lnwebworks’s picture

diksha@lnwebworks commented
Status: Active » Needs review
yashingole’s picture

yashingole commented
StatusFileSize
new Screenshot 2024-03-07 at 3.33.05 PM.png204.03 KB
new Screenshot 2024-03-07 at 3.33.13 PM.png103.49 KB

Verified Patch#2 on 9.5.x and 10, the package name has been updated in info.yml file, RTBC++

swirt made their first commit to this issue’s fork.

swirt’s picture

swirt
he/him
Primary language English
commented

"Other" is an improvement over "custom" but I would like to suggest a group that is more meaningful

I took a look at some of the other modules that do things with login and found no clear winner but a few suggestions.

  • User
  • User authentication
  • User interface

My vote would go to "User"

jminarick made their first commit to this issue’s fork.

jminarick opened merge request !5

majorrobot’s picture

majorrobot commented
Status: Needs review » Reviewed & tested by the community

Good call, @swirt.

@jminarick, I've reviewed this small change and it looks good.

jminarick’s picture

jminarick commented
Status: Reviewed & tested by the community » Fixed
jminarick’s picture

jminarick commented
Status: Fixed » Closed (fixed)
jminarick’s picture

jminarick commented
Status: Closed (fixed) » Needs review
jminarick’s picture

jminarick commented
Status: Needs review » Fixed
jminarick’s picture

jminarick commented
Status: Fixed » Closed (fixed)