Return type of method
Drupal\Tests\yoast_seo\Context\Log::getLogMessages() has
typehint with deprecated class
Drupal\Core\Database\StatementWrapper. Deprecated in
drupal:10.1.0 and is removed from drupal:11.0.0. Use
Drupal\Core\Database\StatementWrapperIterator instead.

Issue fork yoast_seo-3425967

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

himanshu_jhaloya created an issue. See original summary.

melnychukmy made their first commit to this issue’s fork.

melnychukmy opened merge request !29

melnychukmy’s picture

melnychukmy commented

I updated deprecated class usage. Not sure how to confirm that it works. I didn't run Behat test locally but can give it a try. Now I'm waiting for CI result. Unfortunately I noticed that CI fails on latest 8.x-2.x branch.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Active » Postponed

I've skipped this fix for now because it doesn't touch production code for the module and the tests are indeed not running in GitLab. Getting Behat to work there was unfortunately not easy. We can make this change in a way that we can test both Drupal 10 until EOL and Drupal 11 once the tests are fixed :)

Thanks for flagging it!

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Postponed » Fixed

This was fixed in https://git.drupalcode.org/project/yoast_seo/-/commit/70f9ad03fec77180be...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.