Problem/Motivation

When the module is installed it sets the weight considering modules and profiles. But only modules should be considered.

Steps to reproduce

- Install Drupal
- Install the module

The module weight will be set to 1001 when the highest weight is 10 (views module).

Proposed resolution

Only consider modules to set the weight.

Remaining tasks

Create the patch.

Issue fork eu_cookie_compliance-3425868

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

adriancid created an issue. See original summary.

adriancid opened merge request !136

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Active » Needs review
summit’s picture

summit commented

Hi, Will with this change the module weight of the module be something like 11 if 10 is the highest value?
greetings, Martijn

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

@Summit yes, but you can go and use the new release for Modules Weight module too if you need to change the weight.

summit’s picture

summit commented

Hi, The problem is the 1001 of this module, an "add-on" module, cookie_content_blocker needs then to be set to 1002, and that is out of range of the Module Weight Module. That module goes only to 100..
Greetings,

svenryen’s picture

svenryen commented

@adriancid, thanks for helping out. Can you confirm this issue is supposed to focus on 2.x? In that case, is it also related to 8.x-1.x? We most likely will discontinue 2.x.

svenryen’s picture

svenryen commented
Version: 2.0.x-dev » 8.x-1.x-dev
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

@svenryen it was a year ago, I really don't remember, but I think the issue should be in the 8.x version too.

svenryen’s picture

svenryen commented
Issue tags: +Open Ownership Pledge

atowl made their first commit to this issue’s fork.

atowl’s picture

atowl commented

Hi @adriancid,

I've switched this across to 8.x-1.x.

  • atowl committed 6f1b2b6f on 8.x-1.x authored by adriancid 
    Issue #3425868: Only consider modules to set the module weight
atowl’s picture

atowl commented
Status: Needs review » Fixed

Hi @adriancid,
Have merged this in, thanks for your work on the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.