I am in the process of installing version 7.x-1.2 of the openid_connect module on a server running PHP 5.6. However, I encountered an issue where the module didn't function as expected due to certain sections of code utilizing PHP 7 syntax.

To address this issue, I've created a patch that resolves the compatibility problem.

CommentFileSizeAuthor
#3 openid_connect-support_php5-3425839-1.patch1.39 KBchrisguindon

Comments

chrisguindon created an issue. See original summary.

chrisguindon’s picture

chrisguindon commented
Issue summary: View changes
chrisguindon’s picture

chrisguindon commented
StatusFileSize
new openid_connect-support_php5-3425839-1.patch1.39 KB
chrisguindon’s picture

chrisguindon commented
chrisguindon’s picture

chrisguindon commented
jcnventura’s picture

jcnventura
Primary language English
commented

Yes, might make sense to review what other parts of #3395838: Update code style were not yet reverted, and make sure that we do that...

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Reviewed & tested by the community

  • sanduhrs committed 63db7c99 on 7.x-1.x 
    Issue #3425839 by chrisguindon: Support PHP5 with version 7.x-1.2
sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Version: 7.x-1.2 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

I reviewed the other parts of the referenced issue, don't think anything is left.
Thanks.

jcnventura’s picture

jcnventura
Primary language English
commented

Thanks @sanduhrs for the fix. Just commenting to add issue credits to him for the fix, and to me for the RTBC and the investigation on the source of the changes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.