Problem/Motivation

Even with #3425499: Cache tags don't make it through to the toolbar fixed, when you add a new environment, it doesn't show in the toolbar.

This is because the toolbar is only getting cache tags for individual environment entities. When a new entity is created, those tags are not invalidated.

What is needed is the list cache tag.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3425788-8.patch3.93 KBtrackleft2
#7 3425788-7-list-cache-tags.patch5.15 KBtrackleft2

Issue fork environment_indicator-3425788

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joachim created an issue. See original summary.

joachim’s picture

joachim commented
Status: Active » Needs review

This won't work without the fix from #3425499: Cache tags don't make it through to the toolbar also applied.

joachim opened merge request !37

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Needs work

See commit suggestions on the merge request https://git.drupalcode.org/project/environment_indicator/-/merge_request...

atul_ghate made their first commit to this issue’s fork.

atul_ghate’s picture

atul_ghate commented
Status: Needs work » Needs review

HI @trackleft2 , I have worked on the suggested changes, please review.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
StatusFileSize
new 3425788-7-list-cache-tags.patch5.15 KB

Hi @atul_ghate, thanks for your help on this. Adding your change as a patch file.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
StatusFileSize
new 3425788-8.patch3.93 KB

Rerolling patch

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

Tested with these two patches together, and now when I save the configuration forms at either: /admin/config/development/environment-indicator/current or /admin/config/development/environment-indicator the toolbar is updated.

LGTM

            "drupal/environment_indicator": {
                "Toolbar should get the list cache tag, not the individual cache tags (3425788)": "https://www.drupal.org/files/issues/2024-06-05/3425788-8.patch",
                "Cache tags don't make it through to the toolbar (3425499)":"https://www.drupal.org/files/issues/2024-06-05/3425499-8.patch"
            },

isholgueras made their first commit to this issue’s fork.

isholgueras’s picture

isholgueras commented
Status: Reviewed & tested by the community » Fixed

Thanks!

  • isholgueras committed e01de5e5 on 4.x 
    Issue #3425788 by trackleft2, joachim, atul_ghate: toolbar should get...
atul_ghate’s picture

atul_ghate commented

Hi @isholgueras,

Thanks for merging the MR.

I noticed that I wasn't credited for resolving this issue. Could you let me know if there's something I might have missed?

isholgueras’s picture

isholgueras commented

I forgot to check the checkboxes for credit in the merge but I've added later an empty commit with the appropriate credit https://git.drupalcode.org/project/environment_indicator/-/commit/e01de5....

I'll ask to see how it should be done if this is not the way.

isholgueras’s picture

isholgueras commented
atul_ghate’s picture

atul_ghate commented

Hi isholgueras, we can just check the checkbox and save.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.