Doesn't respect published/unpublished status of translations

It's incorrect to fix it in that way:
- hook_entity_access doesn't work with queries and autocomplete fields. So, your changes create new bugs in other places;
- it makes no sense to remove unpublished_node_permissions_node_grants() but still use unpublished_node_permissions_node_access_records() and rebuild node grants on module install.

you can check the difference between access hooks here - https://api.drupal.org/api/drupal/core%21modules%21node%21node.module/gr...

We've had the same issue here and moved to https://www.drupal.org/project/view_unpublished. That module does exacly the same thing, and is more globally used than this one.

I have been working on a patch to fix this issue. We have been testing and it seems to works fine. With this patch, the permissions are saved right for each translations on the node_access table in the database. This patch is to 8.x-1.4 version.

This patch is to 8.x-1.5 version.

Hello,
I add a small change in the patch because the code of version 1.5 changes a little. Instead of:

'realm' => 'view_unpublished_author',
'gid' => $node->getOwnerId(),

I have:

'realm' => 'view_unpublished_author',
'gid' => $node->getOwnerId() ?? 1,

Hello again,

Sorry, I realized that my difference is due to the fact that I have this patch applied also:

https://www.drupal.org/files/issues/2024-03-11/3427115-2.patch

I don't know if the same thing can happen to anyone.

The final patch that fixes both problems. The reason is that gid cannot be null.

Patch doesn't work for me. This makes the module unusable for me -.-

You have to rebuild permissions after you apply the patch

I ran into this problem as well. I fixed it by swapping in the https://www.drupal.org/project/view_unpublished module. Thanks, @jurgenr.

Given the lack of attention to this issue and module and the far lower number of sites using it, I suggest the module be abandoned and sites migrate to view_unpublished.

This is not fixed in 8.x-1.8 — the scenario in the summary still reproduces verbatim on Drupal 11.4. I cannot reopen (maintainers only), so I have filed #3621675: Published translations of a partly unpublished node get no access record, so they 403 for every user with the full analysis and a patch. Noting it here so followers of this issue see it.

Short version: the per-translation patch from #11/#12/#15 did fix the unpublished side — grants are now written per langcode. But unpublished_node_permissions_node_access_records() emits nothing for the published translations, and core only adds its default "all" grant when the whole returned array is empty (NodeAccessControlHandler::acquireGrants()). One unpublished translation makes the array non-empty, so the default is skipped for the entire node, and the published translation ends up with no node_access row at all. NodeGrantDatabaseStorage::access() filters per langcode, so nothing matches and it 403s.

It is symmetric — the mirror case (published original, unpublished translation) fails the same way. And View any unpublished content does not help either, because rows in that realm exist only for the unpublished langcode. Only bypass node access gets through, which is why this looks fine to an administrator.

@quotientix, #16 — I suspect "patch doesn't work for me" was this. Worth retesting with the patch on #3621675: Published translations of a partly unpublished node get no access record, so they 403 for every user.