Bootstrap allows us to use different containers (https://getbootstrap.com/docs/5.3/layout/containers). But currently, page-content component twig template (https://git.drupalcode.org/project/radix/-/blob/6.0.x/components/page-co...) hardcodes the container class for page.header and page.content regions, which can be problematic e.g. when using the layout builder for the landing page layout.

I believe it makes sense to create a prop for this, which would allow fr any value supported by BS5 and "none", which would remove the wrapper div altogether.

I would like to work on this, but I'm not sure if I will be able to do this soon.

Comments

milos.kroulik created an issue. See original summary.

  • Hosisam committed 7796e7f5 on 6.0.x 
    Issue #3425233: page-content component should allow for fluid container...
hosisam’s picture

hosisam commented

I have updated the page-content component to support responsive containers. Here is the updated documentation: https://doxigo.gitbook.io/radix/components/page-content
I'll update the page-footer as well.

hosisam’s picture

hosisam commented
Status: Active » Fixed
milos.kroulik’s picture

milos.kroulik commented

Thanks a lot. Just today I learned that there are cases when no container should be set (https://getbootstrap.com/docs/5.3/layout/gutters/#no-gutters).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.