Problem/Motivation

Steps to reproduce

  • Go to /admin/appearance/settings/[site-name]
  • Select 'Navigation'
  • In Dropdown type select None
  • Save

Observed

Primary menu is broken. Links display vertically down the page.

Expected

Primary menu should no longer open as a drawer/dropdown, single level only. Menu items are linked.
Design: https://www.figma.com/file/H2LrWbmEg1EbSeH1Ljac6n/CivicTheme%3A-Design-S...

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

fionamorrison23 created an issue. See original summary.

fionamorrison23’s picture

Issue summary: View changes
alex.skrypnyk’s picture

It looks like that Drupal does not pass correct variable to disable "Expand all" for level 2+ items.

The solution would be to update the preprocessing for primary navigation.

ivrh’s picture

StatusFileSize
new261.19 KB

@fionamorrison23 can we apply a block-level workaround and restrict the primary navigation block to only show 1 level navigation?
Menu Block options

fionamorrison23’s picture

@ivrh workaround is good, thanks. Regardless, this requires a fix and I'll prioritise is accordingly.

alex.skrypnyk’s picture

Assigned: Unassigned » joshua1234511

This issue needs fixing UI Kit - https://github.com/civictheme/uikit/pull/94

alex.skrypnyk’s picture

Assigned: joshua1234511 » sonam.chaturvedi
Status: Active » Closed (works as designed)
Issue tags: +UIKit

The UIKit PR referenced above was merged within UIKit repository. The UIKit `Navigation` component was not doing what it was saying on the tin - when `Dropdown` had the value `None` selected - the dropdown behaviour was not applied, but the menu structure was preserved, which is not what the UI component should have done, because `Dropdown` property name controls not only the behaviour, but also the look of the component.

As for the Drupal side - this actually works as designed: using the "Number of levels to display" setting is the expected setting to be used to control the number of levels. So this issue is not an issue with Drupal implementation. Closing.

alex.skrypnyk’s picture