Closed (fixed)
Project:
Commerce Core
Version:
8.x-2.x-dev
Component:
Developer experience
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
20 Feb 2024 at 12:30 UTC
Updated:
5 Jun 2024 at 15:41 UTC
Jump to comment: Most recent
Comments
Comment #3
majmunbog commentedComment #6
jsacksick commentedMerged, thank you Ivan!
Comment #8
andyg5000Hey Guys, Thanks for the work on this. This requires an update for anyone that's customized the admin order template. May want to put something in the release notes about that.
Comment #9
jsacksick commentedPerhaps removing the libraries was too brutal... Did that cause you any trouble? But I guess even keeping the files would have been problematic, since the libraries.yml definition was removed right?
Comment #10
andyg5000It just broke the column layout on our admin order page. Not a big deal imo, but end users did have a moment of panic. Just a heads up to check custom templates in the release notes should be fine I think.
Comment #11
andyg5000I've had complaints about `--commerce--layout-content-max-width` too. Not sure why that's constrained to 52rem. It affects the column layout of all the commerce pages like product edit form and order edit form.
Comment #12
jsacksick commentedThe Claro approach was copied, there was a followup issue addressed as the width got reduced on the order view page accidentally too. I'm also not a huge fan of the restricted width for the edit forms, but I guess we just followed Claro's lead.
Comment #13
jsacksick commentedThis is the followup issue for reference: #3447814: Main layout region is too narrow for our entity forms on wide screens.