Closed (fixed)
Project:
Scheduler
Version:
2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Feb 2024 at 16:18 UTC
Updated:
3 Aug 2024 at 09:49 UTC
Jump to comment: Most recent
Now that GitLab templates has #3405955: Add job for CSPELL in contrib pipeline and #3422323: Improve CSPELL we can run CSPELL to fix the spelling errors.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
jonathan1055 commentedStarting position
CSpell: Files checked: 176, Issues found: 723 in 114 files
The downloaded file of spelling errors has precisely 100 words.
Comment #4
jonathan1055 commentedAdded .cspell.json and included two core dictionaries. This reduced the errors
CSpell: Files checked: 176, Issues found: 195 in 59 files
The number of unrecognised words reduced to 69
Comment #5
jonathan1055 commentedAfter the gitlab_templates issue #3422323: Improve CSPELL the top-level files are now being checked, when they were being ignored before. The current position is:
CSpell: Files checked: 195, Issues found: 191 in 60 files
The number of unrecognised/misspelled words is 87
Comment #6
jonathan1055 commentedCSpell: Files checked: 195, Issues found: 15 in 6 files
The number of unrecognised/misspelled words is 5
I am not going to add the five "misspelled" words to the custom dictionary right now as that would simply hide what I think needs investigation. The five words are
$message_parms. I want to know if sub-parts of variable names really have to be full words'name' => $values['title'] ?? $this->randomstring(12), so are all function names forced to be real words?'tnid' => [The keys nid and vid are not reported because the min word length is 4var vals = [];Comment #8
jonathan1055 commentedStarting point for 8.x-1.x
CSpell: Files checked: 117, Issues found: 166 in 50 files
The number of unrecognised/misspelled words is 69
Comment #14
jonathan1055 commentedAll spelling errors fixed in 2.x and 1.x
Comment #15
jonathan1055 commentedComment #17
jonathan1055 commentedThe README "ignore" comments work for ignoring the words, but the comments are rendered in the file. The correct comment style is
<!--- cSpell:disable --->See https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/202...
Comment #19
jonathan1055 commented