Problem/Motivation

@johnpicozzi reported in Slack this:

Quick question here, I see the MR and issue to decouple navigation from Toolbar. However I'm getting a message on my status report that indicates I have the toolbar module installed. Which is true, however it is still a requirement for the navigation module. I'm thinking we may have missed removing it from navigation.info.yml. Is that accurate or am I missing something?

Checked the source code and found it was certainly TRUE.

Reviewed back the issue and MR for #3415311: Decouple from Toolbar module and the dependency was actually removed from the navigation.info.yml file.
However, as part of #3402046: Create the Top Bar the dependency was moved from the bottom to the top of the list.

So, when merging both branches into 1.x, module ended up having the dependency anyway.

Steps to reproduce

Open navigation.info.yml file and confirm that unwanted dependency is there.

Proposed resolution

  • Remove dependency on toolbar module in navigation.info.yml file
  • Confirm that there are no regressions

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork navigation-3421505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc opened merge request !175

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: Remove unnecessary dependency on toolbar module brought back by accident » Remove unwanted dependency on toolbar module brought back by accident
Issue summary: View changes
Status: Active » Needs review
Related issues: +#3415311: Decouple from Toolbar module, +#3402046: Create the Top Bar

MR created.

Please add @johnpicozzi to the credited users list, as he found and reported the bug.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented

Thanks for creating the issue, Will test the MR later today to ensure it resolves the issue. Will report back.

gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Needs review » Reviewed & tested by the community

looks good, can be moved to RTBC.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Needs work

I can disable the Toolbar, but then with Umami Editor and Authors don't have a way to access the administration menus anymore. Not sure if this should be addressed here or in a follow-up.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Reviewed & tested by the community
Related issues: +#3421869: Grant author and editor roles permissions to Navigation module once merged in core

It can be a follow-up. I just checked - navigation becomes visible once i'm granting permissions to "Author" role users in Umami.

Added core task (postponed status).

Restoring RTBC here

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Thanks @kostyashupenko! Merging this in then :)

  • plopesc committed c9923730 on 1.x 
    Issue #3421505: Remove unnecessary dependency on toolbar module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.