Problem/Motivation

Navigation module depends under the hood in Toolbar module.

Steps to reproduce

Disable Toolbar module or remove the access toolbar permission for a specific role and new navigation will disappear.

Proposed resolution

Decouple modules.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork navigation-3415311

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plopesc created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Title: [PP-1] Decouple from Toolbar module » Decouple from Toolbar module
Status: Postponed » Active

This can be activated once #3415234: Add Gitlab CI integration has been merged.

kostyashupenko made their first commit to this issue’s fork.

kostyashupenko opened merge request !165

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review

I'm not backender :) but seems MR helped

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Needs work

Thank you for your valuable work here @kostyashupenko.

Forgot to assign it to myself so we were crossposting.

We ended up with the same solution :)

I'll add a couple of small changes on top of yours

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

I think this is ready for review.

While working on this, I found some inconsistencies in the way navigation items are generated, that lead to inconsistent item IDs and classes in multilingual sites.

Creating a follow-up issue for that purpose.

To test this issue:

  • Enable Navigation and disable Toolbar module
  • Add "Access navigation bar" permission to intended roles
  • Confirm that there are no regressions
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Needs review » Reviewed & tested by the community

Looks great! Thanks for doing this. Nice to see phpstan all clean here as well.

ckrina closed merge request !165

ckrina reopened merge request !165

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.