Closed (fixed)
Project:
Navigation
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 Jan 2024 at 10:33 UTC
Updated:
31 Jan 2024 at 16:24 UTC
Jump to comment: Most recent
Comments
Comment #3
plopescAdded
.gitlab-ci.ymlfile and fixed most of the issues reported.Given that we're getting warnings and not errors, we can merge this as it is and try to fix the remaining issues in followup issues to avoid conflicts.
Comment #4
plopescComment #5
m4oliveiThis looks great to me! Nice to get those phpcs issues tidied up and protect future work from having problems.
Comment #6
m4oliveiThanks for the updates. Context for adding the toolbar dependency: https://drupal.slack.com/archives/C7AB68LJV/p1705497926909629
We'll file a follow up to decouple toolbar completely.
Comment #8
ckrinaFixed. Thank you!!