https://git.drupalcode.org/project/easy_breadcrumb/-/pipelines/95192

Tests do not pass. They should!

Issue fork easy_breadcrumb-3421456

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Greg Boggs created an issue. See original summary.

Jasjeet Kaur Brar made their first commit to this issue’s fork.

Jasjeet Kaur Brar opened merge request !102

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Active » Fixed

Heck Yea!

jasjeet kaur brar’s picture

jasjeet kaur brar commented

Green Tick for phpcs and phpstan across board

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented
Related issues: +#3440889: Broken findMatchingRedirect() call

This was an unfortunate MR. While Stan and CS might have become been green, Unit became red. This MR introduced the bug mentioned in #3440889: Broken findMatchingRedirect() call and #3196198: "Paths to be excluded while generating segments" option says regex is supported, but it is not. Also not the best move switching from static to selfhere, blindly listening to a Stan warning, while you see this pattern nowhere else across any core or contrib code.

The fix now happens in #3440889: Broken findMatchingRedirect() call.

norman.lol’s picture

norman.lol
he/him
Primary language German
Location Berlin
commented

Here we can see clearly what happens if we blindly apply coding standard fixes for credits without understanding the code.