Closed (fixed)
Project:
radix
Version:
6.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2024 at 09:25 UTC
Updated:
28 Feb 2024 at 14:14 UTC
Jump to comment: Most recent
I think more 'if tests' may be added to radix:navbar-brand component to avoid empty span or div outputs.
Before :
{% block logo %}
...
<div class="navbar-brand__text d-flex flex-column">
<span>{{ text }}</span>
{% if site_slogan %}
<span class="small text-muted">{{ site_slogan }}</span>
{% endif %}
</div>
{% endblock %}
After:
{% block logo %}
...
{% if text or site_slogan %} <--- avoids empty div if both are not set
<div class="navbar-brand__text d-flex flex-column">
{% if text %} <--- avoids empty span if not set
<span>{{ text }}</span>
{% endif %}
{% if site_slogan %}
<span class="small text-muted">{{ site_slogan }}</span>
{% endif %}
</div>
{% endif %}
{% endblock %}
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
doxigo commentedGreat catch Philippe, would you mind to open a PR? thanks
Comment #5
doxigo commentedGreat work, merged, thanks.