Problem/Motivation

"TypeError: Drupal\civictheme\Settings\CivicthemeSettingsFormSectionBase::__construct(): Argument #3 ($file_system) must be of type Drupal\Core\File\FileSystem, Drupal\s3fs\S3fsFileService given"

Steps to reproduce

Enable CivicTheme on a site using the S3FS module and try to visit the Settings page.

Proposed resolution

The attached patch updates the code to use FileSystemInterface instead of FileSystem which seems to fix the problem.

CommentFileSizeAuthor
civictheme_error_s3fs.patch2.74 KBtrrroy

Issue fork civictheme-3421274

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

trrroy created an issue. See original summary.

mohd sahzad’s picture

Assigned: Unassigned » mohd sahzad

mohd sahzad’s picture

Assigned: mohd sahzad » Unassigned
Status: Active » Needs review
alex.skrypnyk’s picture

Status: Needs review » Needs work

@Mohd Sahzad
Thank you for your contribution

Please submit PRs to the GitHub Drupal monorepo - https://github.com/civictheme/monorepo-drupal

alex.skrypnyk’s picture

Version: 1.6.2 » 1.7.0
Assigned: Unassigned » joshua1234511
fionamorrison23’s picture

Issue tags: +civictheme-release-1.8

  • 758b63cc committed on 1.x
    Issue #3421274 by joshua1234511, trrroy, mohd-sahzad: TypeError:...

alex.skrypnyk’s picture

Category: Feature request » Bug report
Status: Needs work » Fixed
Issue tags: -civictheme-release-1.8 +civictheme-release-1.7

Fixed an released in 1.7.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.