Pages wraps more and more as the page number gets higher.
First page:
Third page:
Sixth page:
Further pages did not wrap more, I tried up to page 22 :)
This happens on hojtsy.hu, I assume it is not special to the site since I don't have any customization to Olivero yet.
Don't wrap the pager. Not sure how though.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | Cursor_and_Home___Drupal.png | 196.44 KB | mherchel |
| #11 | after.png | 179.69 KB | shweta__sharma |
| #11 | before.png | 138.39 KB | shweta__sharma |
| #7 | Screenshot at Feb 13 14-57-32.png | 128.42 KB | shweta__sharma |
| #2 | Home___Drupal.png | 90.58 KB | mherchel |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mherchelI can't reproduce this with out of the box Drupal. When I look at your site, I do see the issue, but the markup is changed a bit (not sure what's doing it). There's also a sidebar block that's displaying empty markup. That might be related.
Not sure how to troubleshoot this, because I can't reproduce. Ping me in slack and we can figure out time to troubleshoot.
Comment #3
gábor hojtsyThe only block I have in the sidebar is the book navigation block. Eg. https://www.hojtsy.hu/blog/2013-jul-17/drupal-8-multilingual-tidbits-8-t... shows that in action. Its not very well styled, but that is another question :)
Seems like on pages like the front page where there is no book navigation this still produces some whitespace which makes Olivero think there is a sidebar. I think that in itself is a bug. (But this also means that if there is a sidebar, the pager will not be styled properly?)
Comment #4
mherchelYeah, I agree with that. If you disable that block, does it fix the pager issue?
Comment #5
gábor hojtsyThe pager is good when I disable the sidebar block. So I think there are two bugs:
(1) the pager wraps when there is a sidebar block
(2) there looks like whitespace produced from block templates that the main page template thinks is sidebar content
Comment #6
gábor hojtsyIt seems like the Olivero book navigation template override attaches the olivero book library (hah, get it? book library!) even if there is no book tree to display. That may result in some whitespace left around from there? I don't have enough experience to know how whitespace is handled in templates.
Comment #7
shweta__sharma commentedI can confirm this issue when placing any block in the side-bar region the pager wrapped up in the next line.
Unsetting the flex-wrap to
flex-wrap: nowrap;fixed the issue.Comment #10
gauravvvv commentedComment #11
shweta__sharma commentedTested the MR 6591 and it worked fine the pager did not wrap into the next line even if there is a sidebar.
Attached Before/After screenshots
Thanks
Comment #12
gábor hojtsyHow does this look with a tall sidebar? I am not well versed enough in CSS flex to tell sorry :)
Comment #13
mherchelThe current patch needs a different approach. The pager needs to wrap if 1) narrow viewport or 2) user zooms in where the items would otherwise be off the screen. In addition, @Gábor Hojtsy is right that the pager needs to accommodate a sidebar that can potentially have more content than the main region.
@Gábor Hojtsy refers to two issues
However, I'm not sure if we can resolve the first issue because the pager does not know how much content is in the sidebar region. If it overflows, it has to wrap. If the pager were in its own block, we could move it to a different full-width region, but that's not the case.
The main issue here is that we need to make sure that the region markup does not output when content is not present.
Comment #14
mherchelAlso Happy Valentines Day everyone! ♥️
Comment #15
gábor hojtsySome out of the box ideas is if the pager can hide some items towards the end if it would be too wide? Or it can be more tight (less click/touch space) if the space is not enough due to sidebar? The region output IMHO would be its own issue, should I open that one as well?
Comment #16
gábor hojtsyOpened #3421433: sidebar region produces whitespace output that the page template considers is an existing sidebar for sidebar.
Comment #17
mherchelI'm pretty sure the root of the region output issue appears to be #953034: [meta] Themes improperly check renderable arrays when determining visibility, although there are likely ways to work around this.
I'm still not able to reproduce the wrapping issue though. I even set up book, and got the extra element in there, but no wrapping happened.
Comment #18
shweta__sharma commentedTry generating more nodes and check maybe it could be the reason why you are not replicating the wrapping issue.
Comment #20
quietone commentedThe Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.
Comment #21
quietone commentedComment #22
quietone commented