Problem/Motivation

Drupal's GitLab CI template only performs basic PHPStan checks. Those should be much stricter to find problematic code.

Proposed resolution

  • Add a custom phpstan.neon file with level: max to run stricter code quality checks
  • Fix any resulting code quality issues

Remaining tasks

  • Create an issue fork and MR to fix this issue

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork view_mode_switch-3420598

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hctom created an issue. See original summary.

hctom opened merge request !28

hctom’s picture

hctom
Primary language German
commented
Related issues: +#3395419: Allow contrib modules to run PHPStan via GitLab CI
hctom’s picture

hctom
Primary language German
commented
Issue summary: View changes

  • hctom committed 9b1937bd on 2.x 
    Issue #3420598 by hctom: Improve PHPStan checks
hctom’s picture

hctom
Primary language German
commented
Status: Active » Fixed

This is implemented and all reported code quality issues are fixed as well.

hctom’s picture

hctom
Primary language German
commented
Status: Fixed » Closed (fixed)