• Description missed for taxonomy terms in the update as it's not a dependent field.
  • Also, a typo in the README `drush footnotes:upgrade-3-to-4 term` should be `drush footnotes:upgrade-3-to-4 taxonomy_term`.
CommentFileSizeAuthor
#10 2024-02-15_12-08.png11.28 KBscott_euser
#6 descrition-field-for-update-3419898-6.patch7.23 KBcbstuart
#2 descrition-field-for-update-3419898-1.patch1.22 KBcbstuart

Issue fork footnotes-3419898

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

CbStuart created an issue. See original summary.

cbstuart’s picture

cbstuart commented
StatusFileSize
new descrition-field-for-update-3419898-1.patch1.22 KB
scott_euser’s picture

scott_euser commented
Status: Active » Needs work

Thanks for the patch!

Could you create as a merge request please?
Approach is okay, but could be improved by instead getting the config for the base fields as the root problem here is that the existing code is checking for added fields only, and should also check for base fields like taxonomy_term has

So similar to $this->configFactory->listAll('field.storage.' . $entity_type); we should get the base fields and check if they are text, text_long, etc and add as dependants.

Thanks!

cbstuart’s picture

cbstuart commented

Yep, completely agree. I just didn't have time to be fiddling around it. I'll take a look a bit later.

scott_euser’s picture

scott_euser commented

All good, I'm sure your patch will already come in handy for others upgrading who use terms, so it's already a useful contribution as is :)

cbstuart’s picture

cbstuart commented
StatusFileSize
new descrition-field-for-update-3419898-6.patch7.23 KB

New shiny patch for you.

scott_euser’s picture

scott_euser commented
Status: Needs work » Needs review

Nice this looks great, much smarter approach than loading from config. Will have to give this a proper test. Thanks very much for your work on this!

scott_euser opened merge request !33

scott_euser’s picture

scott_euser commented
Assigned: cbstuart » Unassigned
scott_euser’s picture

scott_euser commented
Status: Needs review » Needs work
StatusFileSize
new 2024-02-15_12-08.png11.28 KB

Hmmm when I run this now, the data-text attribute is empty
Screenshot of the WYSIWYG after drush command

Steps:

  1. Added a fn via 3.1.x branch within a paragraph
  2. Updated to this issues branch
  3. Ran the drush command drush footnotes:upgrade-3-to-4 paragraph
scott_euser’s picture

scott_euser commented
Status: Needs work » Needs review

Okay got it, that works now. Turns out that <fn value text></fn> is also an option. Where text is on an attribute instead of within the tag. Added support for that... bit of scope creep here sorry!

  • scott_euser committed cab1bd1e on 4.0.x 
    Issue #3419898 by scott_euser, CbStuart: Description missed for Taxonomy...
scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.