In Commerce Core and some contributed modules, we've established a pattern of linking from contextually relevant user interfaces to third-party service providers, including offers specifically granted to Drupal Commerce merchants. While I strongly believe that establishing these relationships and advertising the existence of these options for merchants is important to the platform as a whole, I also think we should make it easier for developers who don't want these to disable them all via a single setting.
As such, let's establish using a single setting called commerce_show_partner_banners as the tool for disabling these by setting it to FALSE. In Commerce Core, this will need to be respected in the tax type interface where we show the Avalara banner, and we'd need to update Commerce AvaTax accordingly. Let's also ensure we document this in README.md as:
Drupal Commerce modules occasionally link to offers from technology partners in contextually relevant portions of the administrative interface. To simplify disabling these, the project has established a pattern of all such banners respecting a setting you can set in your site's settings.php: $settings['commerce_show_partner_banners'] = FALSE;
Issue fork commerce-3418492
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
vmarchukComment #6
jsacksick commentedComment #7
poker10 commentedCan we add this to 8.x-2.x as well? I think this is pretty important feature request. Thanks!
Comment #8
jsacksick commentedThis was merged to 2.x first. Just not sure why it's not shown here.
Comment #9
vensiresJust in case anyone wants a more ready answer on what’s the solution on this; after installing the latest version including this fix, in your settings file use the following:
It’s clearly stated in the Readme file too.
Thank you for the quick implementation everyone!!
Comment #10
morbus iffThanks @jsacksick!