Problem/Motivation

Discovered when somebody was trying to create the "statistics" project, to bring it from core to contrib. It is not possible because the word "statistics" is a reserved one.

However, that reserved path was removed long ago (in 2013!), in #1827364: Remove issue statistics pages from D7, so it seems like this was a leftover that wasn't removed with it.
Commit: https://git.drupalcode.org/project/project_issue/-/commit/241e0c1

Steps to reproduce

Try to create the "statistics" project.

Proposed resolution

Remove that reserved word as it's no longer used.

Remaining tasks

MR

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 project-issue-mr4.patch624 bytesfjgarlin
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

fjgarlin created an issue. See original summary.

fjgarlin’s picture

Status: Active » Needs review
fgm’s picture

LGTM, but I'm just a bit worried that the tests fail. Is it expected for this module ?

fgm’s picture

Status: Needs review » Reviewed & tested by the community
fjgarlin’s picture

StatusFileSize
new624 bytes

It might be due to #3165307: Dependencies are not fetched for merge request in D7

Uploading patch file to see.

  • dww committed 53afdf01 on 7.x-2.x
    Bug #3417997: Remove 'statistics' as a reserved project word (unused...
dww’s picture

Status: Reviewed & tested by the community » Fixed

Thanks! Reviewed, committed and pushed to 7.x-2.x.

drumm’s picture

This is now deployed. It was actually good that this was reserved, since moving components out of core without coordinating with packages.drupal.org updates is not fun. All core components without existing projects are now reserved in settings.php, https://bitbucket.org/drupalorg-infrastructure/drupal.org/src/9798fe7981...

dww’s picture

That's hilarious - I thought we had the "all core components are reserved" thing in place for years. 😂 Whoops. Glad it's locked down now.

Thanks!
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.