Problem/Motivation

#3151534: "Add another item" field button is displayed as a modal action changed the HTML wrapper class for field buttons from 'form-actions' to 'field-actions'. As a result, some styling supplied by Paragraphs no longer applies.

Steps to reproduce

Configure the Paragraphs widget with a dropbutton in Claro with Drupal 10.2.x

Proposed resolution

Duplicate styling for form-actions to field-actions to support both Drupal 10.1.x and 10.2.x

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

Field actions styling is consistent in Drupal 10.1.x and 10.2.x

API changes

None

Data model changes

None

CommentFileSizeAuthor
#11 3417771-11.patch2.31 KBredwan jamous
#5 Screenshot-D10.2.2-3417771-after.png3.93 KBvanessa.fayard
#5 Screenshot-D10.2.2-3417771-before.png3.89 KBvanessa.fayard
#3 3417771-after.png22.28 KBidebr
#3 3417771-before.png22.31 KBidebr

Issue fork paragraphs-3417771

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !93

idebr’s picture

idebr commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3417771-before.png22.31 KB
new 3417771-after.png22.28 KB

Before:

After:

idebr’s picture

idebr commented
Related issues: +#3151534: "Add another item" field button is displayed as a modal action
vanessa.fayard’s picture

vanessa.fayard commented
StatusFileSize
new Screenshot-D10.2.2-3417771-before.png3.89 KB
new Screenshot-D10.2.2-3417771-after.png3.93 KB

Verified and tested it on a Drupal 10.2.2 and paragraphs module 8.x-1.17.

before :
screenshot before

after :
screenshot after

The patch works fine.

May need to add padding/margin between button and text to improve UX.

djsagar made their first commit to this issue’s fork.

djsagar’s picture

djsagar commented

Try to Address

May need to add padding/margin between button and text to improve UX.

please review.

vanessa.fayard’s picture

vanessa.fayard commented

The patch works fine, thank you for adding a margin to the element.

tart0’s picture

tart0
She/her
Primary language French
Location Nantes, France
commented

Patch works fine, thanks for it !

tart0’s picture

tart0
She/her
Primary language French
Location Nantes, France
commented
Status: Needs review » Reviewed & tested by the community
redwan jamous’s picture

redwan jamous commented
StatusFileSize
new 3417771-11.patch2.31 KB

Thanks for the fix!

Adding a patch file to use with composer...

rossb89’s picture

rossb89 commented

This is working better with 10.2.x, thanks!

Berdir made their first commit to this issue’s fork.

  • Berdir committed de11117c on 8.x-1.x authored by idebr 
    Issue #3417771 by idebr, djsagar: Some styling no longer applies due to...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks, merged.

caesius’s picture

caesius commented
Related issues: +#3350747: Dropbutton has no space to the RHS and its highlight covers adjacent text

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.