Problem/Motivation

At #3417482: [Meta] Pass Eslint validations we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the menu_example sub-module

Initial errors detected by 27/01/2024

/modules/menu_example/menu_example.links.menu.yml
  24:1  error  Expected indentation of 2 spaces but found 3 spaces  yml/indent
  24:4  error  Expected line before comment                         lines-around-comment
  24:4  error  Expected space or tab after '/*' in comment          spaced-comment
modules/menu_example/menu_example.routing.yml
  97:5  error  Expected line before comment  lines-around-comment
modules/menu_example/menu_example.services.yml
  7:7  error  Expected line before comment  lines-around-comment

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: menu_example
  3. Fix the issues found and make a MR with the fixes.

Issue fork examples-3417505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jlbellido created an issue. See original summary.

apaderno made their first commit to this issue’s fork.

apaderno opened merge request !50

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Pass Eslint validations: Menu example » Pass Eslint validations: Menu Example
Status: Active » Needs review

  • apaderno committed cdfabce1 on 4.0.x 
    Issue #3417505: Fix the ESLint errors reported for the Menu Example...
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Pass Eslint validations: Menu Example » Pass ESLint validations: Menu Example
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.