Problem/Motivation

At #3417482: [Meta] Pass Eslint validations we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the events_example sub-module

Initial errors detected by 27/01/2024

/modules/events_example/events_example.services.yml
   9:3  error  Expected line before comment  lines-around-comment
  12:5  error  Expected line before comment  lines-around-comment

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: events_example
  3. Fix the issues found and make a MR with the fixes.

Issue fork examples-3417496

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jlbellido created an issue. See original summary.

jlbellido’s picture

apaderno made their first commit to this issue’s fork.

avpaderno’s picture

Title: Pass Eslint validations: Events example » Pass ESLint validations: Events Example
Status: Active » Needs review

  • apaderno committed 11902621 on 4.0.x
    Issue #3417496: Fix the ESLint errors reported for the Events Example...
avpaderno’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.