Problem/Motivation

At #3417482: [Meta] Pass Eslint validations we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the content_entity_example sub-module

Initial errors detected by 27/01/2024

modules/content_entity_example/content_entity_example.info.yml
  6:1  error  Expected line before comment  lines-around-comment
modules/content_entity_example/content_entity_example.links.action.yml
  4:3  error  Expected line before comment  lines-around-comment
modules/content_entity_example/content_entity_example.links.menu.yml
  10:14  error  Multiple spaces found before 'content_entity_example.contact_settings'  no-multi-spaces
modules/content_entity_example/content_entity_example.links.task.yml
  19:14  error  Multiple spaces found before 'entity.content_entity_example_contact.delete_form'  no-multi-spaces
  20:14  error  Multiple spaces found before 'entity.content_entity_example_contact.canonical'    no-multi-spaces
modules/content_entity_example/content_entity_example.routing.yml
   8:5  error  Expected line before comment                         lines-around-comment
  13:5  error  Expected line before comment                         lines-around-comment
  20:1  error  Expected indentation of 4 spaces but found 2 spaces  yml/indent
  20:3  error  Expected line before comment                         lines-around-comment
  24:1  error  Expected indentation of 4 spaces but found 2 spaces  yml/indent
  24:3  error  Expected line before comment                         lines-around-comment
  30:5  error  Expected line before comment                         lines-around-comment
  34:5  error  Expected line before comment                         lines-around-comment
  42:1  error  Expected indentation of 4 spaces but found 2 spaces  yml/indent
  42:3  error  Expected line before comment                         lines-around-comment
  46:5  error  Expected line before comment                         lines-around-comment
  53:5  error  Expected line before comment                         lines-around-comment
  57:5  error  Expected line before comment                         lines-around-comment

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: content_entity_example
  3. Fix the issues found and make a MR with the fixes.

Issue fork examples-3417494

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jlbellido created an issue. See original summary.

jlbellido’s picture

jlbellido’s picture

apaderno made their first commit to this issue’s fork.

avpaderno’s picture

Title: Pass Eslint validations: Content Entity example » Pass ESLint validations: Content Entity Example
Status: Active » Needs review

  • apaderno committed f357a7d7 on 4.0.x
    Issue #3417494: Fix the ESLint errors reported for the Content Entity...
avpaderno’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.