Problem/Motivation

When clicking the "Edit the embedded entity in tab" button it will always open the same entity. Which is the first selected entity. I have only tested with ckeditor 5.

Steps to reproduce

Embed two entities. Open the first one with the cog. Now open the second. The edit screen for the first entity will open

Proposed resolution

Change the javacsript code for the ckeditor 5 plugin . I will provide a patch.

Remaining tasks

Apply patch

CommentFileSizeAuthor
#10 fix_embedded_entity_open_wrong_entity.patch36.6 KBwlagnadi
#2 edit_the_embedded_entity_open_wrong_entity-3416277-2.patch35.96 KBBram Linssen
Screenshot 2024-01-22 at 16.07.29.png35.88 KBBram Linssen

Issue fork entity_embed-3416277

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Bram Linssen created an issue. See original summary.

Bram Linssen’s picture

Bram Linssen commented
StatusFileSize
new edit_the_embedded_entity_open_wrong_entity-3416277-2.patch35.96 KB
tichris59’s picture

tichris59 commented

Same problem here, with drupal 10.2.2, entity embed 1.5
The patch #2 works like a charm. thanks Bram Linssen !

odensc’s picture

odensc
he/him
commented
Status: Active » Reviewed & tested by the community

Also verified this patch works with Drupal 10.2.2 and entity_embed 1.5.

edmoreta’s picture

edmoreta commented

I confirm the patch works with Drupal 10.2.4 and entity_embed 1.5

  • Dave Reid committed 26c49f93 on 8.x-1.x 
    Issue #3416277 by Bram Linssen: Fixed the Edit the embedded entity in...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Tested and committed #2 to 8.x-1.x. Thank you so much for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wlagnadi’s picture

wlagnadi commented

it is not functional with Drupal 10.4.8 and entity_embed 1.5

wlagnadi’s picture

wlagnadi commented
StatusFileSize
new fix_embedded_entity_open_wrong_entity.patch36.6 KB

worked well when I built the js for build/drupalentity.js again and generated the new patch