Problem/Motivation

On the admin page, the checkbox description states "All links attributes will be recursive removed, except for the /jsonapi response." However, when I tick the checkbox, I find that even the response links (the root links that include the pager links) get removed.

If I'm misunderstanding what this module is supposed to do, I'm sorry, but I think the pager links are supposed to be kept.

Steps to reproduce

Enable this module, turn on link removal, and then visit a JSON:API endpoint.

Proposed resolution

Do not remove the links that are siblings of the JSON:API response.

Issue fork jsonapi_links-3416111

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny opened merge request !3

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review
_tarik_’s picture

_tarik_ commented
Status: Needs review » Fixed

I see the code for this issue was already merged in the scope of this one https://www.drupal.org/project/jsonapi_links/issues/3416149

ptmkenny, please don't combine code for different issues in merge requests in the future. I can understand that you had conflicts between these two patches, but it is better to put a combined version into the comments.

Everything works fine, so the issue can be closed. Thanks for your work!

_tarik_’s picture

_tarik_ commented
Status: Fixed » Closed (fixed)

Added to new module release https://www.drupal.org/project/jsonapi_links/releases/1.0.4