User Story

None

Description

The Quote component is no longer required. This is because a quote can be created within a Content component and it’s not necessary to have two ways of creating the same feature.

The Quote component also has a defect when used on a page without a side navigation (no left padding). The quote within the content component does not have this defect.

We also need a solution for users who are currently using the quote component. The quotes can’t ‘disappear’ and ideally are converted into a quote within a content component.

Acceptance Criteria

AC 1 - available components
Given I’m an authenticated user
When I open the component dropdown to select a component to use
Then I do not see a Quote component option

AC 2 - Existing sites using the ‘Quote' component
Given I’m a user of an existing CivicTheme site
When I check any pages that have used the Quote component
Then I see my content still having a styled quotation

Solution Direction

1. Remove Quote component: configuration, template, preprocess
2. Create an update hook to convert a quote component to a content component with a `

` markup and content from the Quote component within it.
3. Create a test for an update hook to test that the component can be removed and the database can be updated.

Dependencies

This work is blocked by the UIKit https://github.com/civictheme/uikit/issues/97

The UIKit needs to support citations residing within the `

` component markup.
CommentFileSizeAuthor
#8 quote.png327.21 KBsonam.chaturvedi
#7 new.png116.97 KBsonam.chaturvedi
#7 existing.png902.38 KBsonam.chaturvedi

Comments

alex.skrypnyk created an issue. See original summary.

alex.skrypnyk’s picture

Assigned: Unassigned » joshua1234511
Issue summary: View changes
fionamorrison23’s picture

Issue tags: +civictheme-release-1.7
alex.skrypnyk’s picture

  • e04ed6c5 committed on 1.x
    Issue #3415738  by joshua1234511, alex.skrypnyk: Decommissioned the '...
alex.skrypnyk’s picture

Assigned: joshua1234511 » sonam.chaturvedi
Status: Active » Needs review
sonam.chaturvedi’s picture

Assigned: sonam.chaturvedi » joshua1234511
Status: Needs review » Needs work
StatusFileSize
new902.38 KB
new116.97 KB

Verified and tested on 1.x-dev

Testing Results:
1. There is no Quote component option in the component dropdown - PASS
2. BE Quote : the new structure is not correct as 'p' tag is getting added - FAIL
3. FE Quote : the new structure is correct but 'cite' tag style is not getting applied correctly - FAIL

Screenshots :
FE with Quote
existing

BE with Quote
new

Moving to Need work

sonam.chaturvedi’s picture

Assigned: joshua1234511 » alex.skrypnyk
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new327.21 KB

Verified and retested on 1.x-dev

Testing Results:
1. There is no Quote component option in the component dropdown - PASS
2. BE Quote : the new structure has 'p' tag, this is expected - PASS
3. FE Quote : the new structure is correct and 'cite' tag style is getting applied correctly - PASS

Screenshot:
test

RTBC

alex.skrypnyk’s picture

Status: Reviewed & tested by the community » Fixed

Implemented, tested and merged. Will be released in 1.7

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.