Problem/Motivation

Node titles should be themed as per theme colour for a better UI experience. See attached screenshot for reference.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 Screenshot from 2024-01-17 16-28-26.png168.84 KBdineshkumarbollu
Screenshot at Jan 17 14-50-22.png860.18 KBshweta__sharma

Issue fork animal_shelter-3415200

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shweta__sharma created an issue. See original summary.

shweta__sharma opened merge request !6

shweta__sharma’s picture

shweta__sharma commented
Status: Active » Needs review
dineshkumarbollu’s picture

dineshkumarbollu commented
StatusFileSize
new Screenshot from 2024-01-17 16-28-26.png168.84 KB

Hi @shweta__sharma

The MR!6 looks good Changed the Node Title Colour, It will be good other buttons and urls also looks similar colour as Title,like comment,Thanks

shweta__sharma’s picture

shweta__sharma commented
Status: Needs review » Reviewed & tested by the community

As per #4 Moving to RTBC

sourojeetpaul’s picture

sourojeetpaul commented
Status: Reviewed & tested by the community » Needs work

Moving to NW for resolving merge conflicts.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Anonymous’s picture

Anonymous (not verified) commented
Assigned: » Unassigned
Status: Needs work » Needs review

Hey @sourojeetpaul
I resolved the Merge Conflicts on the MR.
Can you please take a look.

esha_kundu made their first commit to this issue’s fork.

esha_kundu’s picture

esha_kundu commented

Hello,
I've resolved the merge conflicts, and I found that the CSS changes for the node color was removed from the file due to which the changes were not being reflected. Hence, I've added it in the css file. Regarding the comment #4 the styling for links in the front page is being addressed in this issue: #3424270. Please review.
Thanks

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Needs work

Hi @esha_kundu,
Thanks for picking this up! The MR is mergable now. But I was wondering if we can improve the styling a lil bit more. Like as of now there's no hover effect on the node titles on the front page, where I feel it'll be better to have a subtle hover effect over there like a growing underline or so! Also I think the styling of the title on individual node pages are not proper at all as well as the alignment. Can we incorporate those changes over here as well?
I'd agree with the suggested changes from @dineshkumarbollu, but as you've mentioned the link related styling is being addressed over other issue, so I'd ignore that on this! Similarly I'd prefer to have a separate issue for the comment section. The whole comment section styling needs to be revamped and aligned properly.

esha_kundu’s picture

esha_kundu commented
Assigned: Unassigned » esha_kundu
esha_kundu’s picture

esha_kundu commented
Assigned: esha_kundu » Unassigned
Status: Needs work » Needs review

Hello,
I've added a growing underline hover effect on the node titles on the front page. Additionally, fixed the alignment on individual node pages. IMO, the title on individual node pages is not represented as a link, hence changing the colour would cause difficulty in differentiating a link and a heading. I also verified with a few other themes and discovered that the node title on the front page is styled with colour and text-decoration, while on the individual page, there is not much styling applied. Bearing this point in mind, I have enlarged the font size of the title, as it appeared too small for a heading on individual node pages. Please review the new changes.
Thanks

sourojeetpaul’s picture

sourojeetpaul commented
Status: Needs review » Fixed

Hi @esha_kundu,
The changes look good to me now. Thanks for your prompt action :)
I'm moving forward with this. Thank you all for your contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.