Problem/Motivation
Tests failed on Drupal 10.2 on latest commit
https://git.drupalcode.org/issue/entity_embed-3415080/-/pipelines
1) Drupal\Tests\entity_embed\FunctionalJavascript\CKEditor5IntegrationTest::testEmbedPreviewAccess with data set "entity_embed filter disabled" (false, true)
RuntimeException: Unable to complete AJAX request.
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php:117
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php:38
/builds/issue/entity_embed-3415080/tests/src/FunctionalJavascript/CKEditor5IntegrationTest.php:670
/builds/issue/entity_embed-3415080/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
2) Drupal\Tests\entity_embed\FunctionalJavascript\ContentTranslationTest::testHostEntityLangcode
WebDriver\Exception\CurlExec: Curl error thrown for http POST to http://localhost:9515/session/56164f3c18475c8263b8672cf87d9b63/element/0.0673952262142008-12/click
Retries: 10 and last result:
{"sessionId":"56164f3c18475c8263b8672cf87d9b63","status":10,"value":{"message":"stale element reference: element is not attached to the page document\n (Session info: headless chrome=106.0.5249.103)\n (Driver info: chromedriver=106.0.5249.61 (511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}),platform=Linux 5.4.241-150.347.amzn2.x86_64 x86_64)"}}
/builds/issue/entity_embed-3415080/vendor/instaclick/php-webdriver/lib/WebDriver/Exception.php:198
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverCurlService.php:148
/builds/issue/entity_embed-3415080/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:125
/builds/issue/entity_embed-3415080/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:240
/builds/issue/entity_embed-3415080/vendor/instaclick/php-webdriver/lib/WebDriver/Container.php:241
/builds/issue/entity_embed-3415080/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:773
/builds/issue/entity_embed-3415080/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:759
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/DrupalSelenium2Driver.php:122
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/DrupalSelenium2Driver.php:202
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/DrupalSelenium2Driver.php:133
/builds/issue/entity_embed-3415080/vendor/behat/mink/src/Element/NodeElement.php:176
/builds/issue/entity_embed-3415080/vendor/behat/mink/src/Element/NodeElement.php:186
/builds/issue/entity_embed-3415080/tests/src/FunctionalJavascript/ContentTranslationTest.php:269
/builds/issue/entity_embed-3415080/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
3) Drupal\Tests\entity_embed\FunctionalJavascript\MediaImageTest::testCkeditorWidgetHasEditableCaption
RuntimeException: Unable to complete AJAX request.
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php:117
/builds/issue/entity_embed-3415080/web/core/tests/Drupal/FunctionalJavascriptTests/JSWebAssert.php:38
/builds/issue/entity_embed-3415080/tests/src/FunctionalJavascript/MediaImageTest.php:546
/builds/issue/entity_embed-3415080/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Steps to reproduce
Proposed resolution
1) Fix tests.
2) Increase test speed.
And add option to run phpunit tests in parallel.
With option: 3 minutes 37 seconds
Without option: 14 minutes 38 seconds
3) Create scheduled pipelines, to run tests each week.
Remaining tasks
3) Create scheduled pipelines, to run tests each week.
Issue fork entity_embed-3415080
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
nikolay shapovalov commentedComment #4
nikolay shapovalov commentedUpdate IS.
Not sure if we need to test next minor, because now it's same as current.
Comment #5
nikolay shapovalov commentedComment #6
nikolay shapovalov commentedComment #7
baluertlI believe this MR should be included first before we move forward with #3430164: Automated Drupal 11 compatibility fixes for entity_embed.
Comment #8
baluertlComment #9
acbramley commentedCan we please get this committed to unblock the other tickets that are blocking D11 support?
Comment #11
ankitv18 commentedClearly tests aren't passing in the current scenario.
D11 compatible pipeline: https://git.drupalcode.org/issue/entity_embed-3430164/-/jobs/3125844
Comment #12
ankitv18 commented@Nikolay Shapovalov @acbramley
Would be helpful if fixing of tests can be done in D11 compatible issue i.e https://www.drupal.org/project/entity_embed/issues/3430164
Comment #13
ankitv18 commentedMoving back to NW to avoid confusion.
Comment #14
ankitv18 commentedI've pushed a commit with marking skippedTests: https://git.drupalcode.org/project/entity_embed/-/merge_requests/47/diff...
Either we can push the maintainer to merge this one: https://git.drupalcode.org/project/entity_embed/-/merge_requests/47
and work on the failing tests in this issue or we can do all test fixing in the D11 issue only.
Comment #15
znerol commented