Needs work
Project:
Magic Code
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
16 Jan 2024 at 14:22 UTC
Updated:
17 Apr 2024 at 13:44 UTC
Jump to comment: Most recent
Currently failed verification attempts via magic code use the user.flood config for the flood event expiry windows.
It would be desirable to use explicit expiry windows for magic code flood events.
Extend the configuration form of the flood_control contrib module to allow easy configuration of flood config of this module.
Comments
Comment #2
chfoidl commentedComment #4
anybody@chfoidl if you're using the core flood services, shouldn't this better live in flood_control module?
#3441460: Add an expiration (setting) for blocked IPs and usernames
You might suggest using flood_control in combination with this module to have all the advanced options and unblocking UI?
Comment #5
chfoidl commented@anybody The
flood_controlcontrib module provides just the UI portion for the Drupal Corefloodmodule's functionality.Configuration of attempt count and expiry window is already part of Drupal Core, but there is no native UI for configuring those parameters.
The
flood_controlcontrib module does not need change anything to support any other module using the flood system. The unblock form supports any event registered via the core flood service, so it naturally works with themagic_codemodule as well.Right now there is no UI to configure the attempt count and expiry window specific to the
magic_codemodule. If you want to configure it right now, you have to set those parameters insettings.php, but it would definetly make sense to expand on theflood_controlconfiguration form to allow configuration of this module's flood settings.Comment #6
chfoidl commentedComment #7
anybodyThank you very very much for your feedback @chfoidl!
Yes I agree. And I think both modules would benefit from that. Nice project btw. I just came across this issue and wanted to let you know :)