Closed (fixed)
Project:
Footnotes
Version:
4.0.0-alpha2
Component:
Footnotes
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Jan 2024 at 17:46 UTC
Updated:
14 Feb 2024 at 09:09 UTC
Jump to comment: Most recent
Comments
Comment #2
scott_euser commentedCan you provide steps/screenshot('s) of how you want to use it? Is it source editing or actual unformatted text? Can you provide example markup of what you expect to work that is being escaped.
Comment #3
john_b commentedHere is a typical footnote
You can see this working correctly on our site. It is currently footnote 59 at https://www.givewell.org/charities/malaria-consortium
Here is the output of the coverted text, which has three problems:
The @...@ delimiters are still there but do not work;
The space at start and end are converted to
tags in 4.x and not in 3.x;
The HTML entities would be a nightmare for content editors to enter, since they create raw HTML.
On the same page, footnote 81 (and many others) have a real apostrophe in "Consortium’s" which is not converted by the drush command. Enter one of those in a footnote when using version 4.x, and that footnote (sometimes all foonotes) break.
Comment #4
john_b commenteddelete
Comment #5
scott_euser commentedThanks for the details. It's certainly not stable yet so there is no commitment to breaking changes in 4x - therefore it is fine and makes sense to as closely as possible match 3x output (while still fixing the various big issues that 3x could never solve like grouping/ama support/wysiwyg support within source, accessibility).
Will work on this as soon as I can. Really appreciate you taking the time to thoroughly test out 4x!
Comment #6
john_b commentedI am grateful that you are so responsive. A look around our content heavy site will show many examples of complex footnotes. Whether we should use a WYSIWYG is an open question, but if Drupal works without one, Footnotes ideally should too.
Comment #7
scott_euser commentedFirst thought is probably the simplest solution is to support putting content within
<footenotes data-value="5">source test here<footnotes/>rather than only supporting data-text. Then perhaps upgrade path can accept as an arg where you want to move the source text to, defaulting to data-text since I would guess the majority of sites use wysiwyg vs not (though I have no data to back that up).To note it probably does need to be data-value and not value as noted in #3391021: Data loss in old 3x version of module: everything before last colon in every footnote is lost when using <fn> instead of [fn] syntax, otherwise it seems some characters cause significant issues.
Will have a bit more of a think about it, and of course also happy to hear your suggestions / opinion.
Comment #8
scott_euser commentedComment #9
scott_euser commentedComment #11
scott_euser commentedThis does not support converting from plain text to CK Editor 5 based text format though. Perhaps that can be a follow-up as its maybe more of an edge case. Can you check if this MR works for you @John_B?
Comment #12
scott_euser commentedUpdated issue summary
Comment #13
scott_euser commentedDrush upgrade command to achieve this as well here #3416959: Combined: Support adding the text content within the <footnotes> element + Drush upgrade path for 3x to 4x
Comment #14
scott_euser commentedFixed as per combined merge request in #3416959: Combined: Support adding the text content within the <footnotes> element + Drush upgrade path for 3x to 4x.