Problem/Motivation

Footnotes Group relies on the content being immediately rendered on the page. Footnotes All Block solves the problem of lazy-built content but using JS to move the footnotes to a Block as noted in #3414345: All footnotes grouped in a block now available in Footnotes main module.

Steps to reproduce

Create a lazy loaded Block with formatted text, using the disable option + Footnotes Group block option in the Footnotes Filter. Any lazy loaded footnotes will not be included in the block.

Proposed resolution

Port the JS from the Footnotes All Block module into this module as a configuration option within the Footnotes Group block.

Remaining tasks

Create MR.

User interface changes

New configuration option in Footnotes Group block.

API changes

None.

Data model changes

None.

Issue fork footnotes-3414443

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

scott_euser created an issue. See original summary.

scott_euser’s picture

Status: Active » Needs work
Issue tags: +Needs tests
scott_euser’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
scott_euser’s picture

Okay test coverage added for this as well. Ready for review for those who use this functionality, but seems to work fine for me on my local tests.

scott_euser’s picture

Status: Needs review » Needs work

Needs resolving of this issue here as well #3221313: Incorrect numbers for footnotes

scott_euser’s picture

Issue tags: +Needs tests

WIP pushed, needs manual testing + automated test coverage, but running out of time myself this morning.

scott_euser’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests

Okay test coverage added for re-numbering after combining

2 reference sections: 1,2 then 1,2
1 combined reference section: 1,2,3,4

  • scott_euser committed 3eccf395 on 4.0.x
    Issue #3414443 by prudloff, srdtwc, tostinni: Provide a JS alternative...
scott_euser’s picture

Status: Needs review » Fixed

Going to merge as is to avoid too many merge conflicts with open branches. Any issues can be raised in follow-ups but hopefully the test coverage means this is quite stable. Also crediting those who helped with Footnotes All Block module at #3221313: Incorrect numbers for footnotes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.