Problem/Motivation

Eslint fails in Starterkit "lint" script if there are no JS files in components

Steps to reproduce

1. Create a subtheme from the sarterkit without examples (use the flag available in the script)
2. Run `npm run lint`

Observer error:

```
No files matching the pattern "./components/**/*.js" were found.
Please check for typing mistakes in the pattern.
```

Proposed resolution

Add ESLint flag `--no-error-on-unmatched-pattern` to `civictheme_starter_kit/package.json` to suppress the message.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Comments

alex.skrypnyk created an issue. See original summary.

alex.skrypnyk’s picture

alex.skrypnyk
he/him
Primary language English
Location Melbourne
commented
alex.skrypnyk’s picture

alex.skrypnyk
he/him
Primary language English
Location Melbourne
commented
Assigned: alex.skrypnyk » joshua1234511
joshua1234511’s picture

joshua1234511
Primary language English
Location Goa
commented
Assigned: joshua1234511 » alex.skrypnyk
Status: Active » Needs review

Pull Request https://github.com/civictheme/monorepo-drupal/pull/1205

  • f7b2be54 committed on 1.x 
    Issue #3414203 by joshua1234511: Eslint fails in Starterkit "lint"...
alex.skrypnyk’s picture

alex.skrypnyk
he/him
Primary language English
Location Melbourne
commented
Assigned: alex.skrypnyk » joshua1234511
Status: Needs review » Fixed

Implemented, tested and merged. Will be released in 1.7

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.