Problem/Motivation

Eslint is currently disabled in gitlab-ci.yml

Steps to reproduce

Run any pipeline

Proposed resolution

Comment out this bit in gitlab-ci.yml

variables:
  SKIP_ESLINT: '1'

Fix any eslint errors

Issue fork footnotes-3413947

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !18

scott_euser’s picture

scott_euser commented
Title: Enable Eslinting » Enable Eslinting and fix any coding standards issues shown

thakurnishant_06 changed the visibility of the branch 3413947- to hidden.

thakurnishant_06 changed the visibility of the branch 3413947- to active.

thakurnishant_06 opened merge request !19

thakurnishant_06 closed merge request !19

thakurnishant_06’s picture

thakurnishant_06 commented
Status: Active » Needs review

Hi @scotteuser,
Fixed all the errors and warnings reported by the Eslint , Kindly review the changes.
Thank you.

  • scott_euser committed 2469c413 on 4.0.x 
    Issue #3413947 by thakurnishant_06: Enable Eslinting and fix any coding...
scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Great, thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.