Currently, messages are logged with a severity level of "notice" when creating or updating menu through the UI. These activities are normal functionality of the menu_ui module and should be logged with a severity level of "info" if logging at all.
Log in as a user with permission to administer menu and menu links.
Turn on DBLog module.
Create or update a menu.
Check the DBLog report, note that normal activity of creating or updating a menu is logged with a severity level of "notice".
Downgrade logged messages reflecting normal functions of the menu_ui module from "notice" to "info", as per the Syslog protocol, messages that confirm that a program is working as expected should be logged as Informational messages.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3412152-nr-bot.txt | 961 bytes | needs-review-queue-bot |
| #2 | 3412152-2-downgrading-menu-changes-from-notice-to-info.patch | 1.2 KB | lisa.rae |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
lisa.rae commentedComment #3
lisa.rae commentedComment #4
smustgrave commentedCaused a number of test failures.
Comment #5
arisenComment #7
arisenUpdated the task summary as the issue is related to Menu not Menu Items.
Jenkins pipeline seems to throw unrelated issues. Added MR.
Comment #8
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #12
smustgrave commentedMinor improvement, think it's small enough to not need tests.
Comment #14
dcam commentedI looked at this issue. I don't agree with the change based on what I found. My brief tour of Core showed that bundle-level changes are logged as notice, not info. I'm not sure how bundles work within the menu system, but there's another way to look at it. Actions that alter the configuration of a website are logged as notice. That's true of creating menus. IMO, anything that alters configuration is a significant event because they represent something that needs to be checked into version control lest the change be lost.
I'm setting the status to Postponed for more information. Please feel free to respond with additional rationale for making this change. Otherwise, the issue may be closed after some time with no response.
Comment #16
smustgrave commentedSince there's been no follow up going to close out.