Fix phpcs Drupal.Files.LineLength issues [#3411807]

Problem/Motivation

Fix phpcs errors for

Drupal.Files.LineLength

Command:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/custom/pathauto/ --sniffs="Drupal.Files.LineLength"

Result:


FILE: tests/src/Functional/PathautoNodeWebTest.php
----------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------
 208 | WARNING | Line exceeds 80 characters; contains 92 characters
     |         | (Drupal.Files.LineLength.TooLong)
 225 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: tests/src/Kernel/PathautoTokenTest.php
---------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------
 38 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------


FILE: tests/src/FunctionalJavascript/PathautoUiTest.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 107 | WARNING | Line exceeds 80 characters; contains 97 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: pathauto.module
---------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------
 16 | WARNING | Line exceeds 80 characters; contains 88 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------


FILE: src/AliasUniquifier.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 105 | WARNING | Line exceeds 80 characters; contains 81 characters
     |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: src/PathautoWidget.php
----------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 149 characters
    |         | (Drupal.Files.LineLength.TooLong)
----------------------------------------------


FILE: src/AliasCleanerInterface.php
---------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------
 16 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
 55 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------


FILE: src/AliasUniquifierInterface.php
---------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------
 13 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
---------------------------------------------

Time: 1.13 secs; Memory: 8MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#14	pathauto-MR66.png	49.23 KB	roberttabigue
#11	pathauto_MR!66-after.png	77.63 KB	roberttabigue
#11	pathauto_MR!66-before.png	507.21 KB	roberttabigue

Issue fork pathauto-3411807

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3411807-fix-phpcs-drupal.files.linelength changes, plain diff MR !66
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

1 January 2024 at 23:31

Nikolay Shapovalov created an issue. See original summary.

Comment #2

2 January 2024 at 05:55

Nikolay Shapovalov opened merge request !66

Comment #3

nikolay shapovalov commented 2 January 2024 at 05:57

Status:

Needs work

» Needs review

MR is ready for review.

Used fix for src/PathautoWidget.php same as in #3411792: Fix phpcs Drupal.WhiteSpace, Squiz.WhiteSpace issues.

Comment #4

sidharth_soman commented 2 January 2024 at 06:42

Probably should have

// Ensure that cleanTokenValues() does not alter this token value.

rather than

// Ensure that the cleanTokenValues() does not alter this token value.

in tests/src/Kernel/PathautoTokenTest.php. It looks better grammatically.

Comment #5

nikolay shapovalov commented 18 January 2024 at 07:39

Update MR, add phpcs.xml file and exclude rules that will be fixed in different issues.
Gitlab CI check phpcs passed.

Comment #6

nikolay shapovalov commented 7 February 2024 at 15:06

Removed changes from PathautoWidget.php because there is separate task #3418158: Remove leftover from src/PathautoWidget.php.

Comment #7

a.aaronjake commented 16 July 2024 at 02:45

Status:

Needs review

» Needs work

Hi @Nikolay Shapovalov,

Your latest changes on MR66 was applied successfully, however one error still not fixed. Please see below:

pathauto git:(0f4b566) curl https://git.drupalcode.org/project/pathauto/-/merge_requests/66.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6204    0  6204    0     0  17368      0 --:--:-- --:--:-- --:--:-- 18034
patching file pathauto.module
patching file src/AliasCleanerInterface.php
patching file src/AliasUniquifier.php
patching file src/AliasUniquifierInterface.php
patching file tests/src/Functional/PathautoNodeWebTest.php
patching file tests/src/FunctionalJavascript/PathautoUiTest.php
patching file tests/src/Kernel/PathautoTokenTest.php
➜  web git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/pathauto/ --sniffs="Drupal.Files.LineLength"

FILE: ...o-site/drupal-orgissue/web/modules/contrib/pathauto/src/PathautoWidget.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 35 | WARNING | Line exceeds 80 characters; contains 146 characters
--------------------------------------------------------------------------------

Time: 666ms; Memory: 12MB

Kindly check

Thanks,
Jake

Comment #8

24 October 2025 at 20:42

jeremy1606 made their first commit to this issue’s fork.

Comment #9

santanu mondal commented 27 October 2025 at 13:00

Assigned:

Unassigned

» santanu mondal

Comment #10

santanu mondal commented 28 October 2025 at 07:34

Assigned:	santanu mondal	» Unassigned
Status:	Needs work	» Needs review

Comment #11

roberttabigue commented 30 October 2025 at 10:15

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	pathauto_MR!66-before.png	507.21 KB
new	pathauto_MR!66-after.png	77.63 KB

Hi,

I have applied the latest MR!66 to the Pathauto module with 8.x-1.x-dev and confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig pathauto/ --sniffs="Drupal.Files.LineLength"

Please see the attached files for reference.

I'm moving this now to ‘RTBC’.

Thank you!

Comment #12

berdir

German

Switzerland

commented 30 October 2025 at 13:11

Status:

Reviewed & tested by the community

» Needs work

Reviewed.

This includes a lot more than just line length issues.

Comment #13

jerech commented 6 December 2025 at 05:10

Status:

Needs work

» Needs review

Comment #14

roberttabigue commented 19 January 2026 at 18:29

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	pathauto-MR66.png	49.23 KB

Hi,

I have applied the latest MR!66 to the Pathauto module (8.x-1.x-dev) on my local Drupal setup, confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig pathauto/ --sniffs="Drupal.Files.LineLength"

Please see the attached file for reference.

I'm moving this now to "RTBC".

Thank you!

Comment #15

mably commented 11 February 2026 at 22:24

Status:

Reviewed & tested by the community

» Fixed

Comment #16

11 February 2026 at 22:24

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Comment #17

mably commented 11 February 2026 at 22:29

Status:

Fixed

» Closed (fixed)

Fix phpcs Drupal.Files.LineLength issues

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork pathauto-3411807

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Parent issue

Related issues

News items

Our community

Documentation

Drupal code base

Governance of community