There are few remaining, would be nice to get that green as well.

Issue fork ds-3411201

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swentel created an issue. See original summary.

omkar-pd made their first commit to this issue’s fork.

omkar-pd opened merge request !27

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review
swentel’s picture

swentel commented
Status: Needs review » Needs work

Thanks for working on those. It's still throwing errors, so I guess this needs work.

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review

eslint passed.

swentel’s picture

swentel commented
Status: Needs review » Needs work

Nice job! Two problems though: the summary information is now broken. If you go to /admin/structure/ds/settings and select something in the 'Other' or 'BC settings' tab, the values aren't printed. Will have a look if I can help out there, it's really close!

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review

Working now.

swentel’s picture

swentel commented

Awesome, thank you!

swentel’s picture

swentel commented
Status: Needs review » Fixed

merged into the branch

swentel’s picture

swentel commented
Status: Fixed » Closed (fixed)