Problem/Motivation

Sometimes in the feeds, we can receive URLs (to images for example) with uppercase schema.

The HTTPS://example.com and https://example.com are the same URLs but in the module, the differences are detected as invalid schema.

Steps to reproduce

Here we can try 2 cases:

1) Try to create a feed with HTTPS://example.com/feed.xml URL.
2) Or, you can create a feed with a valid URL, but provide a mapping to upload images from the feed where the path to images will be with uppercase schema.

Proposed resolution

The URL should be converted into a lowercase by default before validation.

Comments

tibezh created an issue. See original summary.

tibezh’s picture

Assigned: tibezh » Unassigned
StatusFileSize
new3.33 KB
new3.86 KB

Here a few patches with and without tests.

tibezh’s picture

Status: Active » Needs review

I thing we can review it.

klausi’s picture

Status: Needs review » Needs work

thanks, I think we should not change the domain or URL path and leave them as is. You never know when a path would be interpreted case sensitive. We want to only lower case the protocol part from HTTP to http.

tibezh’s picture

Status: Needs work » Needs review
StatusFileSize
new3.78 KB
new686 bytes

Yeah, you are right @klausi, attached a different patch with an interdiff.

klausi’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, nice!

joelpittet’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for this, I have committed it to latest dev branch

  • joelpittet committed 60c0ebfb on 7.x-2.x
    Issue #3410254 by tibezh, klausi: FeedsHTPRequestException failed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.