Problem/Motivation
Sometimes in the feeds, we can receive URLs (to images for example) with uppercase schema.
The HTTPS://example.com and https://example.com are the same URLs but in the module, the differences are detected as invalid schema.
Steps to reproduce
Here we can try 2 cases:
1) Try to create a feed with HTTPS://example.com/feed.xml URL.
2) Or, you can create a feed with a valid URL, but provide a mapping to upload images from the feed where the path to images will be with uppercase schema.
Proposed resolution
The URL should be converted into a lowercase by default before validation.
Comments
Comment #2
tibezh commentedHere a few patches with and without tests.
Comment #3
tibezh commentedI thing we can review it.
Comment #4
klausithanks, I think we should not change the domain or URL path and leave them as is. You never know when a path would be interpreted case sensitive. We want to only lower case the protocol part from HTTP to http.
Comment #5
tibezh commentedYeah, you are right @klausi, attached a different patch with an interdiff.
Comment #6
klausiThanks, nice!
Comment #7
joelpittetThanks for this, I have committed it to latest dev branch