Closed (fixed)
Project:
Simplenews
Version:
4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Dec 2023 at 09:35 UTC
Updated:
19 Mar 2024 at 12:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
kbrodej commentedComment #4
berdirThis can only be done when the project requires 10.2, otherwise it breaks functionality on lower versions.
And it's not just about removing the translate class, categories are machine names now, so it will need to be decided where this fits in the new category system.
Comment #5
himanshu_jhaloya commentedHi,
To maintain compatibility, where categories are represented by machine names, you can define a custom category and use its machine name.
Comment #6
himanshu_jhaloya commentedComment #7
ressaThanks @himanshu_jhaloya. Manually attaching patches is being phased out, so perhaps you can create a patch and Merge Request with the Gitlab integration.
DrupalCI and all patch testing will be turned off on July 1, 2024
Already today, from the test page for this issue:
Comment #8
adamps commentedPostponed until June 2024 when support for D10.1 ends - see #4
Comment #9
berdirThat's tricky because EOL for 10.1 might also be when 11.0 gets released (yep, that soon already).
This is what we did in entity_reference_revisions:
So put the new category into the annotation and then switch back in the info hook.
But looking again at the change, this is even easier. this is no_ui field type, the category was just copy pasted but is useless here as it is, per no_ui = TRUE, never actually shown in the UI.
So, just remove the category, problem solved.
Comment #10
adamps commentedThanks @Berdir let's try it
Comment #11
adamps commentedPlease can someone review/confirm that this fixes the problem?
> Manually attaching patches is being phased out, so perhaps you can create a patch and Merge Request with the Gitlab integration.
Yes but it's not currently working unfortunately see #3395901: Use Gitlab CI in Simplenews
Comment #12
berdirShould be OK IMHO. Didn't test, but there's really not much that you can test as it doesn't show up anywhere ;)
Comment #13
ressaAh yes ... it's a race against time now, since DrupalCI and all patch testing will be turned off on July 1, 2024.
If it isn't created already, someone should create a meta "support group" issue for module maintainers struggling with the transition to Gitlab CI tests :)
Comment #14
berdirThere's the #gitlab channel on Slack for asking questions, but this might be a bit too advanced for that.
FWIW, this doesn't prevent creating merge requests, they still run DrupalCI tests as well.
Comment #16
adamps commentedGreat thanks