[1.x] Calendar event notifications

Please check and fix all phpcs first

FILE: /var/www/html/testing/web/modules/custom/calendar_event_notifications/css/calendar_event_notifications.css
----------------------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AFFECTING 26 LINES
----------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] CSS colours must be defined in lowercase; expected #04aa6d but found #04AA6D
28 | ERROR | [x] CSS colours must be defined in lowercase; expected #04aa6d but found #04AA6D
29 | ERROR | [x] Blank lines are not allowed in class definitions
40 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
40 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
45 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
45 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
50 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
53 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
53 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
55 | ERROR | [ ] Style definitions must end with a semicolon
56 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
57 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
57 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
64 | ERROR | [x] Expected 1 newline at end of file; 0 found
64 | ERROR | [x] Additional whitespace found at end of file
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/testing/web/modules/custom/calendar_event_notifications/js/calendar_event_notifications.js
--------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------------------------------------------
4 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
5 | ERROR | [x] Whitespace found at end of line
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
19 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
20 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
31 | ERROR | [x] Whitespace found at end of line
34 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
97 | ERROR | [x] Whitespace found at end of line
98 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
114 | ERROR | [x] Expected 1 newline at end of file; 3 found
116 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

Time: 255ms; Memory: 12MB

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

For this application, only commits from @MuskanM are allowed. Not from another user.

In this case, @RamaiyaA had given a review and made a code commit.

1. FILE: calendar_event_notifications.info.yml

package: Custom

That line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

2. FILE: calendar_event_notifications.module

The description for a module is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

Hi @MuskanM

Great module and contribution! Keep it up, man. Here are some things to check/fix:

• Remove all the uuid: lines from the config/install/* folder
• no README, no composer.json. Add them, please, and do that according to the Drupal standards.
• Check indentation and formatting for js/calendar_event_notifications.js. It's hard to read and understand it.
• Don't use anonymous functions statement like this click(function (e) { but like this click((e) => {
• File: src/Form/CalendarEventNotificationsSettingsForm.php. Defining the $form before the customization is better. For instance: $form = parent::buildForm($form, $form_state); after line 56, then, the rest of the implementation. There is a token support logic on the line 96. Then, why don't you check it and save it here submitForm? Put all strings in $this->t() function, please. For example: 'Remainder for your upcoming event',
• File: calendar_event_notifications.module. For example, the function calendar_event_notifications_node_presave, don't use if inside another if and so on in the places where you can add an &&

Kind regards
Andrei

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries' post on Responsible maintainers
• Maintainership
• Git version control system
• Issue procedures and etiquette
• Maintaining and responding to issues for a project
• Release naming conventions.

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.