Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Given that Coder implements all core code style + more (best practices, etc.), we should remove code-style.pl.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | empty.patch | 338 bytes | grendzy |
| #10 | 340940_remove_code_style_pl.patch.txt | 5.29 KB | grendzy |
| #8 | empty.patch | 1 byte | grendzy |
| #6 | 340940_remove_code_style_pl.patch | 5.29 KB | grendzy |
| #5 | 340940_remove_code_style_pl.patch | 5.26 KB | grendzy |
Comments
Comment #1
John Morahan CreditAttribution: John Morahan commented+1. Coder has the advantage that PHP programmers (i.e. Drupal developers) can contribute to its development and maintenance. Would be nice if it would chase HEAD though.
Comment #3
Dave ReidSince this script hasn't really been updated since Feb 2007, I'm going to agree this could be much better maintained in the coder module.
Comment #4
grendzy CreditAttribution: grendzy commentedI tend to agree (Although one downside of relying on coder is it's not available yet for D7).
code-style.pl when run on the current codebase produces a ton of "no mixed case function or variable names" errors, and also hasn't been updated for the new string concat style.
Comment #5
grendzy CreditAttribution: grendzy commentedNow that coder has a release for 7, let's give this another try.
Comment #6
grendzy CreditAttribution: grendzy commenteddoh. re-rolling from the right directory. ;-)
Comment #8
grendzy CreditAttribution: grendzy commentedtrying to keep pifr happy.
Comment #10
grendzy CreditAttribution: grendzy commentedComment #11
grendzy CreditAttribution: grendzy commentedComment #12
Dries CreditAttribution: Dries commentedHell, yes. Committed.
Comment #13
Damien Tournoud CreditAttribution: Damien Tournoud commentedI don't believe this got committed.
Comment #14
Dries CreditAttribution: Dries commentedCommitted now! Thanks.